build: disable UT testing multiple node versions - #23709
Merged
Merged
Conversation
alan-agius4
added
the
target: patch
alan-agius4
force-pushed
the
bazel-node-js-multiple
branch
from
August 9, 2022 09:43
a3d5864 to
1b2216f
Compare
alan-agius4
marked this pull request as ready for review
August 9, 2022 09:43
With this change we disable running UTs on multiple node.js versions. This is mainly an interim solution until we find the root cause of the memory increase and OOM errors during bazel test. During this change I also noticed that the toolchain was configured incorrectly. Setting the toolchain to use Node.js 16 causes the App-shell tests to fail when used under Bazel. See: https://app.circleci.com/pipelines/github/angular/angular-cli/25009/workflows/4ea86ec8-d1f7-4c91-8810-76f10f8e878c/jobs/325982
alan-agius4
force-pushed
the
bazel-node-js-multiple
branch
from
August 9, 2022 10:53
1b2216f to
59d0190
Compare
Collaborator
Author
|
//cc @jbedard |
alan-agius4
added
the
action: review
clydin
approved these changes
Aug 9, 2022
alan-agius4
added
action: merge
Contributor
|
FWIW this issue seems similar? nrwl/nx#10537 This is an option for now disabling the failing test and splitting the node 14 vs 16 into separate CI steps: #23714 |
Collaborator
Author
It is similar, but the unlike the issue, the actually builder works when run outside of Bazel. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change we disable running UTs on multiple node.js versions. This is mainly an interim solution until we find the root cause of the memory increase and OOM errors during bazel test.
During this change I also noticed that the toolchain was configured incorrectly. Setting the toolchain to use Node.js 16 causes the App-shell tests to fail when used under Bazel. See: https://app.circleci.com/pipelines/github/angular/angular-cli/25009/workflows/4ea86ec8-d1f7-4c91-8810-76f10f8e878c/jobs/325982